Skip to content

fix: use public Node API instead of internal View methods #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nabim777 merged 2 commits into from
Oct 9, 2025
Merged

fix: use public Node API instead of internal View methods #908

nabim777 merged 2 commits into from
Oct 9, 2025
+17 −12

Conversation

@nabim777
Copy link
Collaborator

@nabim777 nabim777 commented Oct 8, 2025 •
edited
Loading

Description

Following recent Nextcloud changes (#55574) where the View class marked as @internal, this PR replaces DirectUploadController to use the recommended Node API instead.
A similar approach is used in other apps like files_zip
Documentation for the Node API used is available at:
https://docs.nextcloud.com/server/stable/developer_manual/basics/storage/filesystem.html#direct-storage-access

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@nabim777 nabim777 self-assigned this Oct 8, 2025
@nabim777 nabim777 force-pushed the ci/fix-psalm-error branch 4 times, most recently from 14ef661 to ee79dfa Compare October 9, 2025 04:11
@nabim777
fix: use public Node API instead of internal View methods
d14ec44 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 force-pushed the ci/fix-psalm-error branch from ee79dfa to d14ec44 Compare October 9, 2025 04:11
@nabim777 nabim777 marked this pull request as ready for review October 9, 2025 06:44
@nabim777 nabim777 force-pushed the ci/fix-psalm-error branch from 3cdf08d to 71a8c46 Compare October 9, 2025 09:52
saw-jan
saw-jan reviewed Oct 9, 2025
View reviewed changes
saw-jan
saw-jan reviewed Oct 9, 2025
View reviewed changes
individual-it
individual-it approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and to prove it works we have an API test that still passes: https://github.com/nextcloud/integration_openproject/blob/master/tests/acceptance/features/api/getFileinfoByFileIDAPI.feature#L1355

@nabim777
sisable constructor in phpunit test
8a2cd47 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 force-pushed the ci/fix-psalm-error branch from 71a8c46 to 8a2cd47 Compare October 9, 2025 10:27
@nabim777 nabim777 merged commit 0db96e7 into master Oct 9, 2025
12 checks passed
@nabim777 nabim777 deleted the ci/fix-psalm-error branch October 9, 2025 10:51
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saw-jan saw-jan saw-jan approved these changes

@individual-it individual-it individual-it approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc is a code owner

@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash is a code owner

@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein is a code owner

@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus is a code owner

@lindenthal lindenthal Awaiting requested review from lindenthal lindenthal is a code owner

@psatyal psatyal Awaiting requested review from psatyal psatyal is a code owner

@wielinde wielinde Awaiting requested review from wielinde wielinde is a code owner

@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare is a code owner

Assignees

@nabim777 nabim777

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nabim777 @individual-it @saw-jan